[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    Re: [PATCH] [lld] Add basic linker script parsing.
From:       Michael Spencer <bigcheesegs () gmail ! com>
Date:       2013-02-28 22:39:21
Message-ID: 09de238d18752b4ca05e876f7097b80d () llvm-reviews ! chandlerc ! com
[Download RAW message or body]



================
Comment at: lib/ReaderWriter/LinkerScript.cpp:51-59
@@ +50,11 @@
+  switch (c) {
+  case 'A': case 'B': case 'C': case 'D': case 'E': case 'F': case 'G':
+  case 'H': case 'I': case 'J': case 'K': case 'L': case 'M': case 'N':
+  case 'O': case 'P': case 'Q': case 'R': case 'S': case 'T': case 'U':
+  case 'V': case 'W': case 'X': case 'Y': case 'Z':
+  case 'a': case 'b': case 'c': case 'd': case 'e': case 'f': case 'g':
+  case 'h': case 'i': case 'j': case 'k': case 'l': case 'm': case 'n':
+  case 'o': case 'p': case 'q': case 'r': case 's': case 't': case 'u':
+  case 'v': case 'w': case 'x': case 'y': case 'z':
+  case '_': case '.': case '$': case '/': case '\\':
+    return true;
----------------
Dmitri Gribenko wrote:
> Shankar Kalpathi Easwaran wrote:
> > parts of these can use isalpha, in ctype.h 
> Please don't.  isalpha() and friends are locale-dependent.
> 
Yep, that's explicitly why I didn't use them.


http://llvm-reviews.chandlerc.com/D477
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
[prev in list] [next in list] [prev in thread] [next in thread]