[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    Re: [llvm] r176270 - Re-format comments (and check commit access)
From:       Yiannis Tsiouris <gtsiour () softlab ! ntua ! gr>
Date:       2013-02-28 22:20:39
Message-ID: 512FD837.3060009 () softlab ! ntua ! gr
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi all!

I got more than 10 buildbot failure notifications from this commit! How
is this even possible! :D Should I just ignore them? make check-all
works great for me!

yiannis

On 02/28/2013 06:59 PM, Yiannis Tsiouris wrote:
> Author: tsiou
> Date: Thu Feb 28 10:59:10 2013
> New Revision: 176270
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=176270&view=rev
> Log:
> Re-format comments (and check commit access)
> 
> Modified:
> llvm/trunk/lib/Target/X86/X86FrameLowering.cpp
> 
> Modified: llvm/trunk/lib/Target/X86/X86FrameLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FrameLowering.cpp?rev=176270&r1=176269&r2=176270&view=diff
>  ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86FrameLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86FrameLowering.cpp Thu Feb 28 10:59:10 2013
> @@ -1386,7 +1386,6 @@ HasNestArgument(const MachineFunction *M
> return false;
> }
> 
> -
> /// GetScratchRegister - Get a temp register for performing work in the
> /// segmented stack and the Erlang/HiPE stack prologue. Depending on platform
> /// and the properties of the function either one or two registers will be
> @@ -1612,22 +1611,21 @@ X86FrameLowering::adjustForSegmentedStac
> #endif
> }
> 
> -// Erlang programs may need a special prologue to handle the stack size they
> -// might need at runtime. That is because Erlang/OTP does not implement a C
> -// stack but uses a custom implementation of hybrid stack/heap
> -// architecture. (for more information see Eric Stenman's Ph.D. thesis:
> -// http://publications.uu.se/uu/fulltext/nbn_se_uu_diva-2688.pdf)
> -//
> -//
> -// CheckStack:
> -//	temp0 = sp - MaxStack
> -//	if( temp0 < SP_LIMIT(P) ) goto IncStack else goto OldStart
> -// OldStart:
> -//	...
> -// IncStack:
> -//	call inc_stack   # doubles the stack space
> -//	temp0 = sp - MaxStack
> -//	if( temp0 < SP_LIMIT(P) ) goto IncStack else goto OldStart
> +/// Erlang programs may need a special prologue to handle the stack size they
> +/// might need at runtime. That is because Erlang/OTP does not implement a C
> +/// stack but uses a custom implementation of hybrid stack/heap architecture.
> +/// (for more information see Eric Stenman's Ph.D. thesis:
> +/// http://publications.uu.se/uu/fulltext/nbn_se_uu_diva-2688.pdf)
> +///
> +/// CheckStack:
> +///	  temp0 = sp - MaxStack
> +///	  if( temp0 < SP_LIMIT(P) ) goto IncStack else goto OldStart
> +/// OldStart:
> +///	  ...
> +/// IncStack:
> +///	  call inc_stack   # doubles the stack space
> +///	  temp0 = sp - MaxStack
> +///	  if( temp0 < SP_LIMIT(P) ) goto IncStack else goto OldStart
> void X86FrameLowering::adjustForHiPEPrologue(MachineFunction &MF) const {
> const X86InstrInfo &TII = *TM.getInstrInfo();
> MachineFrameInfo *MFI = MF.getFrameInfo();
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits@cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- 
Yiannis Tsiouris
Ph.D. student,
Software Engineering Laboratory,
National Technical University of Athens
WWW: http://www.softlab.ntua.gr/~gtsiour


["signature.asc" (application/pgp-signature)]

_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]