[prev in list] [next in list] [prev in thread] [next in thread]
List: llvm-commits
Subject: Re: [test-suite] r176238 - Change 252.eon and 447.dealII to explicitly build with libstdc++.
From: Bob Wilson <bob.wilson () apple ! com>
Date: 2013-02-28 20:40:15
Message-ID: B064F3D0-E023-415F-9A46-0084006C9F0F () apple ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Feb 28, 2013, at 12:37 PM, Eric Christopher <echristo@gmail.com> wrote:
>
>
>
> On Thu, Feb 28, 2013 at 12:35 PM, Bob Wilson <bob.wilson@apple.com> wrote:
> If they were bugs in libc++, I wouldn't have done this!
>
>
> Heh. Mostly meant "hey, workaround to test the rest of the compiler while waiting \
> on libc++" as a possibility.
> There were multiple problems. These are old C++ programs using non-standard \
> libstdc++ headers and doing other bad stuff.
>
> Ick.
>
> Thanks :)
>
> -eric
The comment before this part of the patch really says everything that needs to be \
said:
# Yes, we know this is an old crufty C++ benchmark. Don't tell us about it GCC!
-CXXFLAGS += -fno-exceptions -Wno-deprecated -Wno-non-template-friend -fpermissive
+CXXFLAGS += -fno-exceptions -Wno-deprecated -Wno-non-template-friend -fpermissive \
-stdlib=libstdc++
447.dealII was not quite so bad.
>
>
> On Feb 28, 2013, at 12:29 PM, Eric Christopher <echristo@gmail.com> wrote:
>
> > Curiosity:
> >
> > What issues? Bug in libc++ or the testcase?
> >
> > -eric
> >
> >
> > On Wed, Feb 27, 2013 at 11:57 PM, Bob Wilson <bob.wilson@apple.com> wrote:
> > Author: bwilson
> > Date: Thu Feb 28 01:57:20 2013
> > New Revision: 176238
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=176238&view=rev
> > Log:
> > Change 252.eon and 447.dealII to explicitly build with libstdc++.
> > They both have issues when using libc++.
> >
> > Modified:
> > test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile
> > test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile
> >
> > Modified: test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile
> > URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile?rev=176238&r1=176237&r2=176238&view=diff
> > ==============================================================================
> > --- test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile (original)
> > +++ test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile Thu Feb 28 \
> > 01:57:20 2013 @@ -16,6 +16,7 @@ CPPFLAGS += \
> > -Ddeal_II_dimension=3 \
> > -DBOOST_DISABLE_THREADS \
> > -I$(SPEC_BENCH_DIR)/src/include
> > +CXXFLAGS += -stdlib=libstdc++
> >
> > STDOUT_FILENAME := log
> >
> >
> > Modified: test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile
> > URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile?rev=176238&r1=176237&r2=176238&view=diff
> > ==============================================================================
> > --- test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile (original)
> > +++ test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile Thu Feb 28 01:57:20 \
> > 2013 @@ -57,7 +57,7 @@ Source = $(addprefix $(SPEC_BENCH_DIR)/s
> > mrXYRectangle.cc mrXZRectangle.cc mrYZRectangle.cc myrand.cc)
> >
> > # Yes, we know this is an old crufty C++ benchmark. Don't tell us about it GCC!
> > -CXXFLAGS += -fno-exceptions -Wno-deprecated -Wno-non-template-friend \
> > -fpermissive +CXXFLAGS += -fno-exceptions -Wno-deprecated \
> > -Wno-non-template-friend -fpermissive -stdlib=libstdc++
> > LDFLAGS = -lstdc++ -lm
> > LIBS = -lm
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits@cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
>
[Attachment #5 (text/html)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space; "><br><div><div>On Feb 28, 2013, at \
12:37 PM, Eric Christopher <<a \
href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><br><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Feb 28, 2013 at 12:35 \
PM, Bob Wilson <span dir="ltr"><<a href="mailto:bob.wilson@apple.com" \
target="_blank">bob.wilson@apple.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div style="word-wrap:break-word">If they were bugs in \
libc++, I wouldn't have done this!<div><br></div></div></blockquote> \
<div><br></div><div style="">Heh. Mostly meant "hey, workaround to test the rest of \
the compiler while waiting on libc++" as a \
possibility.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 \
0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div \
style="word-wrap:break-word"><div></div><div>There were multiple problems. \
These are old C++ programs using non-standard libstdc++ headers and doing other \
bad stuff.<div><div class="h5"><br></div></div></div></div></blockquote> \
<div><br></div><div style="">Ick.</div><div style=""><br></div><div style="">Thanks \
:)</div><div style=""><br></div><div \
style="">-eric</div></div></div></div></blockquote><div><br></div>The comment before \
this part of the patch really says everything that needs to be \
said:</div><div><br></div><div># Yes, we know this is an old crufty C++ benchmark. \
Don't tell us about it GCC!<br>-CXXFLAGS += -fno-exceptions -Wno-deprecated \
-Wno-non-template-friend -fpermissive<br>+CXXFLAGS += -fno-exceptions -Wno-deprecated \
-Wno-non-template-friend -fpermissive -stdlib=libstdc++<br><br>447.dealII was not \
quite so bad.</div><div><br><blockquote type="cite"><div dir="ltr"><div \
class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div style="word-wrap:break-word"><div \
class="h5"><div><br></div><div>On Feb 28, 2013, at 12:29 PM, Eric Christopher <<a \
href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> \
wrote:</div> <div><div><br><blockquote type="cite"><div \
dir="ltr">Curiosity:<div><br></div><div>What issues? Bug in libc++ or the \
testcase?</div><div><br></div><div>-eric</div></div><div \
class="gmail_extra"><br><br><div class="gmail_quote"> On Wed, Feb 27, 2013 at 11:57 \
PM, Bob Wilson <span dir="ltr"><<a href="mailto:bob.wilson@apple.com" \
target="_blank">bob.wilson@apple.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Author: bwilson<br>
Date: Thu Feb 28 01:57:20 2013<br>
New Revision: 176238<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=176238&view=rev" \
target="_blank">http://llvm.org/viewvc/llvm-project?rev=176238&view=rev</a><br> \
Log:<br> Change 252.eon and 447.dealII to explicitly build with libstdc++.<br>
They both have issues when using libc++.<br>
<br>
Modified:<br>
test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile<br>
test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile<br>
<br>
Modified: test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile?rev=176238&r1=176237&r2=176238&view=diff" \
target="_blank">http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CFP \
2006/447.dealII/Makefile?rev=176238&r1=176237&r2=176238&view=diff</a><br>
==============================================================================<br>
--- test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile (original)<br>
+++ test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile Thu Feb 28 01:57:20 \
2013<br> @@ -16,6 +16,7 @@ CPPFLAGS += \<br>
-Ddeal_II_dimension=3 \<br>
-DBOOST_DISABLE_THREADS \<br>
-I$(SPEC_BENCH_DIR)/src/include<br>
+CXXFLAGS += -stdlib=libstdc++<br>
<br>
STDOUT_FILENAME := log<br>
<br>
<br>
Modified: test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile?rev=176238&r1=176237&r2=176238&view=diff" \
target="_blank">http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CIN \
T2000/252.eon/Makefile?rev=176238&r1=176237&r2=176238&view=diff</a><br>
==============================================================================<br>
--- test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile (original)<br>
+++ test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile Thu Feb 28 01:57:20 \
2013<br> @@ -57,7 +57,7 @@ Source = $(addprefix $(SPEC_BENCH_DIR)/s<br>
mrXYRectangle.cc mrXZRectangle.cc \
mrYZRectangle.cc myrand.cc)<br> <br>
# Yes, we know this is an old crufty C++ benchmark. Don't tell us about \
it GCC!<br>
-CXXFLAGS += -fno-exceptions -Wno-deprecated -Wno-non-template-friend \
-fpermissive<br> +CXXFLAGS += -fno-exceptions -Wno-deprecated \
-Wno-non-template-friend -fpermissive -stdlib=libstdc++<br> <br>
LDFLAGS = -lstdc++ -lm<br>
LIBS = -lm<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" \
target="_blank">llvm-commits@cs.uiuc.edu</a><br> <a \
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" \
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br> \
</blockquote></div><br></div> </blockquote></div><br></div></div></div>
</blockquote></div><br></div></div>
</blockquote></div><br></body></html>
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic