[prev in list] [next in list] [prev in thread] [next in thread]
List: llvm-commits
Subject: Re: [llvm-commits] [compiler-rt] r153735 - /compiler-rt/trunk/lib/atomic.c
From: Chandler Carruth <chandlerc () google ! com>
Date: 2012-03-31 9:23:44
Message-ID: CAGCO0KgFkRTS9_Lf2+MGEt6AMdotx2QuYx3yAA+sPOxhfgvLsQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Sat, Mar 31, 2012 at 2:22 AM, David Chisnall <csdavec@swan.ac.uk> wrote:
> On 31 Mar 2012, at 10:20, Chandler Carruth wrote:
>
> > On Fri, Mar 30, 2012 at 3:45 PM, Chandler Carruth <chandlerc@google.com>
> wrote:
> > On Fri, Mar 30, 2012 at 5:46 AM, David Chisnall <csdavec@swan.ac.uk>
> wrote:
> > I can disable that if __LP64__ is not defined, but I think a better
> solution would be for clang to support __uint128_t in 32-bit mode...
> >
> > David, please revert this patch and discuss this on the mailing list
> until these issues are addressed. This is why we have pre-commit review.
> >
> > David has clarified that review did take place, but apparantly off-list.
> =/ I wish that weren't happening.
> >
> > Anyways, could we at least disable this temporarily? Leaving the build
> broken isn't reasonable...
>
> If you read the bug report and check the commit log, you'll see that the
> __uint128_t case was disabled yesterday, fixing the build on 32-bit
> platforms...
>
Ah, thanks. I missed that commit. My apologies, I had just flagged this
thread to follow and not checked for other threads that might be relevant.
[Attachment #5 (text/html)]
<div class="gmail_quote">On Sat, Mar 31, 2012 at 2:22 AM, David Chisnall <span \
dir="ltr"><<a href="mailto:csdavec@swan.ac.uk">csdavec@swan.ac.uk</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"> <div class="HOEnZb"><div class="h5">On 31 Mar 2012, at \
10:20, Chandler Carruth wrote:<br> <br>
> On Fri, Mar 30, 2012 at 3:45 PM, Chandler Carruth <<a \
href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:<br> > On \
Fri, Mar 30, 2012 at 5:46 AM, David Chisnall <<a \
href="mailto:csdavec@swan.ac.uk">csdavec@swan.ac.uk</a>> wrote:<br> > I can \
disable that if __LP64__ is not defined, but I think a better solution would be for \
clang to support __uint128_t in 32-bit mode...<br> ><br>
> David, please revert this patch and discuss this on the mailing list until these \
issues are addressed. This is why we have pre-commit review.<br> ><br>
> David has clarified that review did take place, but apparantly off-list. =/ I \
wish that weren't happening.<br> ><br>
> Anyways, could we at least disable this temporarily? Leaving the build broken \
isn't reasonable...<br> <br>
</div></div>If you read the bug report and check the commit log, you'll see that \
the __uint128_t case was disabled yesterday, fixing the build on 32-bit \
platforms...<br></blockquote><div><br></div><div>Ah, thanks. I missed that commit. My \
apologies, I had just flagged this thread to follow and not checked for other threads \
that might be relevant.</div> </div>
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic