'[LLVMbugs] [Bug 21682] New: TrieEdge leak in MachONormalizedFileBinaryWriter.cpp'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-bugs
Subject:    [LLVMbugs] [Bug 21682] New: TrieEdge leak in MachONormalizedFileBinaryWriter.cpp
From:       bugzilla-daemon () llvm ! org
Date:       2014-11-27 12:17:26
Message-ID: bug-21682-206 () http ! llvm ! org/bugs/
[Download RAW message or body]

--1417090646.48F30.22243
Date: Thu, 27 Nov 2014 06:17:26 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"

http://llvm.org/bugs/show_bug.cgi?id=21682

            Bug ID: 21682
           Summary: TrieEdge leak in MachONormalizedFileBinaryWriter.cpp
           Product: lld
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: All Bugs
          Assignee: unassignedbugs@nondot.org
          Reporter: devlists@shadowlab.org
                CC: llvmbugs@cs.uiuc.edu
    Classification: Unclassified

TrieNode uses a SmallVector to store TrieEdge children.
But TrieNode is allocated using an llvm::bumpPtr allocator, and so its
destructor is never invoked when the memory is freed. As a result the
SmallVector destructor is never call either, and as the SmallVector is not
allocator aware, the memory managed by the SmallVector leaks.

A possible solution would be to use an other structure to store the TrieEdge
(chained list) that does not require additional memory allocation.
TrieEdge will contain a pointer to its sibling, and will be allocated using the
llvm bumpPtr allocator.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

--1417090646.48F30.22243
Date: Thu, 27 Nov 2014 06:17:26 -0600
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"

<html>
    <head>
      <base href="http://llvm.org/bugs/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - TrieEdge leak in MachONormalizedFileBinaryWriter.cpp"
   href="http://llvm.org/bugs/show_bug.cgi?id=21682">21682</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>TrieEdge leak in MachONormalizedFileBinaryWriter.cpp
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>lld
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>unspecified
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>All Bugs
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedbugs&#64;nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>devlists&#64;shadowlab.org
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>llvmbugs&#64;cs.uiuc.edu
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr></table>
      <p>
        <div>
        <pre>TrieNode uses a SmallVector to store TrieEdge children.
But TrieNode is allocated using an llvm::bumpPtr allocator, and so its
destructor is never invoked when the memory is freed. As a result the
SmallVector destructor is never call either, and as the SmallVector is not
allocator aware, the memory managed by the SmallVector leaks.

A possible solution would be to use an other structure to store the TrieEdge
(chained list) that does not require additional memory allocation.
TrieEdge will contain a pointer to its sibling, and will be allocated using the
llvm bumpPtr allocator.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>

--1417090646.48F30.22243--

_______________________________________________
LLVMbugs mailing list
LLVMbugs@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmbugs

[prev in list] [next in list] [prev in thread] [next in thread] 