'[LLVMbugs] [Bug 18852] Spelling correction to non-static member functions with qualification'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-bugs
Subject:    [LLVMbugs] [Bug 18852] Spelling correction to non-static member functions with qualification
From:       bugzilla-daemon () llvm ! org
Date:       2014-02-28 18:22:17
Message-ID: bug-18852-206-iX9naxRIOR () http ! llvm ! org/bugs/
[Download RAW message or body]

--1393611738.B4c85e3.2415
Date: Fri, 28 Feb 2014 12:22:18 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"

http://llvm.org/bugs/show_bug.cgi?id=18852

Kaelyn Takata <rikka@google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassignedclangbugs@nondot. |rikka@google.com
                   |org                         |

--- Comment #1 from Kaelyn Takata <rikka@google.com> ---
r202520 disables suggesting non-static members in cases where they cannot work,
such as when the correction is not during a member lookup. While explaining
that an instance is required may be nice (and possible future work), I think it
may be going a bit further out on a limb than the diagnostics typically do...
except perhaps in cases where the correction has the same base spelling as the
original identifier and there aren't any other feasible corrections, such as in
the reduced test case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

--1393611738.B4c85e3.2415
Date: Fri, 28 Feb 2014 12:22:18 -0600
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"

<html>
    <head>
      <base href="http://llvm.org/bugs/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:rikka&#64;google.com" \
title="Kaelyn Takata &lt;rikka&#64;google.com&gt;"> <span class="fn">Kaelyn \
Takata</span></a> </span> changed
              <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - Spelling correction to non-static member functions with \
qualification"  href="http://llvm.org/bugs/show_bug.cgi?id=18852">bug 18852</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Status</td>
           <td>NEW
           </td>
           <td>RESOLVED
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Resolution</td>
           <td>---
           </td>
           <td>FIXED
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Assignee</td>
           <td>unassignedclangbugs&#64;nondot.org
           </td>
           <td>rikka&#64;google.com
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - Spelling correction to non-static member functions with \
qualification"  href="http://llvm.org/bugs/show_bug.cgi?id=18852#c1">Comment # 1</a>
              on <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - Spelling correction to non-static member functions with \
qualification"  href="http://llvm.org/bugs/show_bug.cgi?id=18852">bug 18852</a>
              from <span class="vcard"><a class="email" \
href="mailto:rikka&#64;google.com" title="Kaelyn Takata \
&lt;rikka&#64;google.com&gt;"> <span class="fn">Kaelyn Takata</span></a> </span></b>
        <pre>r202520 disables suggesting non-static members in cases where they \
cannot work, such as when the correction is not during a member lookup. While \
explaining that an instance is required may be nice (and possible future work), I \
think it may be going a bit further out on a limb than the diagnostics typically \
do... except perhaps in cases where the correction has the same base spelling as the
original identifier and there aren't any other feasible corrections, such as in
the reduced test case.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>

--1393611738.B4c85e3.2415--

_______________________________________________
LLVMbugs mailing list
LLVMbugs@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmbugs

[prev in list] [next in list] [prev in thread] [next in thread] 