[prev in list] [next in list] [prev in thread] [next in thread]
List: live-patching
Subject: Re: [PATCH v1 4/5] livepatch: Add sample livepatch module
From: Petr Mladek <pmladek () suse ! com>
Date: 2024-01-05 14:14:05
Message-ID: ZZgOrSgNGQGpJ6_L () alley
[Download RAW message or body]
On Mon 2023-11-06 17:25:12, Lukas Hruska wrote:
> From: Josh Poimboeuf <jpoimboe@redhat.com>
>
> Add a new livepatch sample in samples/livepatch/ to make use of symbols
> that must be post-processed to enable load-time relocation resolution.
> As the new sample is to be used as an example, it is annotated with
> KLP_RELOC_SYMBOL macro.
>
> The livepatch sample updates the function cmdline_proc_show to print the
> string referenced by the symbol saved_command_line appended by the
> string "livepatch=1".
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Signed-off-by: Lukas Hruska <lhruska@suse.cz>
> ---
> samples/livepatch/Makefile | 1 +
> .../livepatch/livepatch-annotated-sample.c | 84 +++++++++++++++++++
The name is ambiguous. I would use something like livepatch-extern-symbol.c
Also it would be great to prepare a selftest. In this case, I would
suggest to livepatch a symbol from another test module so that
it does not modify the running system and the result is predictable.
Otherwise it looks good. With a better module name:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic