[prev in list] [next in list] [prev in thread] [next in thread] 

List:       live-patching
Subject:    Re: [PATCH v11 1/2] x86/module: remove unused code in __apply_relocate_add
From:       Joe Lawrence <joe.lawrence () redhat ! com>
Date:       2023-01-27 13:45:47
Message-ID: Y9PVi7WoaBu8KdR2 () redhat ! com
[Download RAW message or body]

On Wed, Jan 25, 2023 at 10:54:00AM -0800, Song Liu wrote:
> This "#if 0" block has been untouched for many years. Remove it to clean
> up the code.
> 
> Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Signed-off-by: Song Liu <song@kernel.org>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> ---
>  arch/x86/kernel/module.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c
> index 705fb2a41d7d..1dee3ad82da2 100644
> --- a/arch/x86/kernel/module.c
> +++ b/arch/x86/kernel/module.c
> @@ -188,10 +188,6 @@ static int __apply_relocate_add(Elf64_Shdr *sechdrs,
>  				goto invalid_relocation;
>  			val -= (u64)loc;
>  			write(loc, &val, 4);
> -#if 0
> -			if ((s64)val != *(s32 *)loc)
> -				goto overflow;
> -#endif
>  			break;
>  		case R_X86_64_PC64:
>  			if (*(u64 *)loc != 0)
> -- 
> 2.30.2
> 

Reviewed-by: Joe Lawrence <joe.lawrence@redhat.com>

--
Joe

[prev in list] [next in list] [prev in thread] [next in thread]