[prev in list] [next in list] [prev in thread] [next in thread] 

List:       live-patching
Subject:    Re: [PATCH v4 bpf-next 2/4] ftrace: allow IPMODIFY and DIRECT ops on the same function
From:       Steven Rostedt <rostedt () goodmis ! org>
Date:       2022-07-19 23:27:15
Message-ID: 20220719192715.2b93ef70 () gandalf ! local ! home
[Download RAW message or body]

On Tue, 19 Jul 2022 23:24:35 +0000
Song Liu <songliubraving@fb.com> wrote:

> Actually, we cannot blindly lock direct_mutex here, as 
> register_ftrace_direct() already locks it before calling 
> register_ftrace_function(). We still need the if (IPMODIFY)
> check. 

Let's not play games with this then.

Create a register_ftrace_function_nolock()

and use that for register_ftrace_direct().

Otherwise it's going to be a nightmare to keep track of.

-- Steve
[prev in list] [next in list] [prev in thread] [next in thread]