[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linuxsh-dev
Subject:    Re: delayed switching
From:       Paul Mundt <lethal () linux-sh ! org>
Date:       2007-05-11 2:29:42
Message-ID: 20070511022942.GA24698 () linux-sh ! org
[Download RAW message or body]

Hi Saito-san,

On Fri, May 11, 2007 at 11:07:26AM +0900, Hideo Saito wrote:
> On Thu, 10 May 2007 14:15:26 +0900, Paul Mundt wrote:
> > No, consider the use case where a platform implements pm_idle() and
> > depends on certain conditions to be met to determine what sort of
> > power-save state can be entered. It's still necessary to have the logic
> > in default_idle() and to have that exported so it can be called back in
> > to from pm_idle(), should the latter not have any meaningful work it can
> > do at the time.
> 
> I see, but I think following change in default_idle() does not need.
> 
> +       } else
> +               while (!need_resched())
> +                       cpu_relax();
> 
> how about following change?
> 
> +       } else
>                 cpu_relax();
> 
That's fine as well. I shoved the while (!need_resched()) in there so we
wouldn't have to retest hlt_counter in the common case. hlt/nohlt is
something that's specified at boot, or by the board setup code, it's not
something that warrants a lot of retesting once we're booted.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
linuxsh-dev mailing list
linuxsh-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxsh-dev
[prev in list] [next in list] [prev in thread] [next in thread]