[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linuxppc64-dev
Subject:    [PATCH] hvcs - comment, printk, and functionality cleanup
From:       rsa () us ! ibm ! com (Ryan Arnold)
Date:       2004-05-11 19:29:15
Message-ID: 1084303756.16102.2005.camel () SigurRos ! rchland ! ibm ! com
[Download RAW message or body]


On Mon, 2004-05-10 at 19:17, Benjamin Herrenschmidt wrote:
> You are still using workqueues, I think that's wrong ...
>
> Note also that cancel_delayed_work() will only cancel the timer, the
> task may still pop up if the timer expired.

Thanks for the reply Ben.

I'm going to check this patch into the Ameslab tree to provide the
current version of hvcs with the latest fixes I have.

I'm taking your advice.  I had prepared an hvcs patch for the LKML
(formal drivers submission) that I'll wait on delivering until I rewrite
the driver with kernel threads rather than workqueues.

Ryan S. Arnold

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/




[prev in list] [next in list] [prev in thread] [next in thread]