[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linuxppc-embedded
Subject:    Re: [PATCH v2 10/14] cxlflash: Remove AFU command lock
From:       Uma Krishnan <ukrishn () linux ! vnet ! ibm ! com>
Date:       2016-11-30 22:12:28
Message-ID: 8d9dd4f3-ff12-8a0c-16ee-da2a28b9f275 () linux ! vnet ! ibm ! com
[Download RAW message or body]

> From: "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
>
> The original design of the cxlflash driver required AFU commands
> to convey state information across multiple threads. The IOASA
> "host use" byte was used to track if a command was done, errored,
> or timed out. A per-command spin lock was used to serialize access
> to this byte. As this is no longer required with the introduction
> of completions and various refactoring over time, the spin lock,
> state tracking, and associated code can be removed. To support the
> simplification, the wait_resp() routine is refactored to return a
> success or failure. Additionally, as the simplification to the
> AFU internal command routine, explicit assignments of AFU command
> fields to zero are removed as the memory is zeroed upon allocation.
>
> Signed-off-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>

Acked-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>

[prev in list] [next in list] [prev in thread] [next in thread]