[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linuxppc-embedded
Subject:    Re: [PATCH] powerpc: Fix xmon for systems without MSR[RI]
From:       Jimi Xenidis <jimix () pobox ! com>
Date:       2011-08-31 21:08:48
Message-ID: 372EB5CE-5331-4B30-973F-87005D4402CF () pobox ! com
[Download RAW message or body]


On Aug 30, 2011, at 1:08 PM, Scott Wood wrote:

> On 08/30/2011 01:11 AM, Benjamin Herrenschmidt wrote:
>> On Mon, 2011-08-08 at 16:25 -0500, Jimi Xenidis wrote:
>>> From: David Gibson <dwg@au1.ibm.com>
>>> 
>>> Based on patch by David Gibson <dwg@au1.ibm.com>
>>> 
>>> xmon has a longstanding bug on systems which are SMP-capable but lack
>>> the MSR[RI] bit.  In these cases, xmon invoked by IPI on secondary
>>> CPUs will not properly keep quiet, but will print stuff, thereby
>>> garbling the primary xmon's output.  This patch fixes it, by ignoring
>>> the RI bit if the processor does not support it.
>>> 
>>> There's already a version of this for 4xx upstream, which we'll need
>>> to extend to other RI-lacking CPUs at some point.  For now this adds
>>> BookE processors to the mix.
>> 
>> Don't freescale one have RI ?
> 
> e500mc does.

hmm, according to the ISA, MSR[RI] is only defined for Book3s and is not defined for Book3e
Should we scope it to just book3e?
-jx

> 
> e500v2 doesn't -- if a machine check happens while MSR[ME]=0, it causes
> a checkstop.
> 
> -Scott
> 

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
[prev in list] [next in list] [prev in thread] [next in thread]