[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linuxppc-dev
Subject:    [PATCH 5/6] fix warning on test_ti_thread_flag()
From:       paulus () samba ! org (Paul Mackerras)
Date:       2006-01-26 4:12:37
Message-ID: 17368.19509.43692.401946 () cargo ! ozlabs ! ibm ! com
[Download RAW message or body]

Akinobu Mita writes:

> I can fix this without changing the flags size for those architectures.
> 
> 1. Introduce *_le_bit() bit operations which takes void *addr
>    (already I have these functions in the scope of
>     HAVE_ARCH_EXT2_NON_ATOMIC_BITOPS in my patch)
> 
> 2. Change flags to __u8 flags[4] or __u8 flags[8] for each architectures.
> 
> 3. Use *_le_bit() in include/linux/thread_info.h

Please don't do this, you'll break the powerpc assembly code that
tests bits in thread_info()->flags.

Paul.


[prev in list] [next in list] [prev in thread] [next in thread]