[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linuxppc-dev
Subject:    TEST: Sleep patch #4
From:       benh () kernel ! crashing ! org (Benjamin Herrenschmidt)
Date:       2004-11-23 23:27:03
Message-ID: 1101252423.24531.23.camel () gaston
[Download RAW message or body]


> Looking at radeon_base.c:radeon_screen_blank() (line 1045) we have:
> 
>                         val &= ~(LVDS_BL_MOD_EN);
>                         udelay(100);
>                         val &= ~(LVDS_ON | LVDS_EN);
>                         OUTREG(LVDS_GEN_CNTL, val);
> 
> 
> Is there an OUTREG(LVDS_GEN_CNTL, val); missing before the udelay(100) ??
> 
> That's in the panel blank code, not the unblank code though. Doesn't seem
> to hurt to put the OUTREG in.

won't hurt, dunno if it will help tho... could also be a different
issue, like the spread spectrum PLL not locking properly or something
like that ... I don't really know.

Ben.




[prev in list] [next in list] [prev in thread] [next in thread]