[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linuxbios
Subject:    [coreboot] Re: Critical bug in RTC code for a leap year
From:       Matt DeVillier <matt.devillier () gmail ! com>
Date:       2024-02-29 15:16:31
Message-ID: CAFTm+6AY5+zgFL9VLjeeGKA2DWPfw6p843guDCKhBu1D3RY1kg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, Feb 29, 2024 at 4:59 AM Michał Żygowski <michal.zygowski@3mdeb.com>
wrote:

> Hi folks,
>
> Another leap year, another problem with RTC in firmwares :) This time,
> unfortunately, this kind of bugs hit coreboot.
>
> I have issued a patch that fixes off-by-one error in the days count in
> month for a leap year:
> https://review.coreboot.org/c/coreboot/+/80790
>
> It is quite critical, because depending on build date, it may revert to
> some very old date, like January 2023 or even older (depending on how
> long you run on current firmware). That said, the consequences are
> enormous: from false-negative expired certificates, to problems with
> filesystems, etc.
>
> It is worth considering an emergency coreboot release, is it not?
>

I suppose we could CP to the 2402 branch and tag a 2402.1 release if
there's sufficient desire for a tagged release with the fix


>
> Best regards,
>
> --
> Michał Żygowski
> Firmware Engineer
> GPG: 6B5BA214D21FCEB2
> https://3mdeb.com | @3mdeb_com
> _______________________________________________
> coreboot mailing list -- coreboot@coreboot.org
> To unsubscribe send an email to coreboot-leave@coreboot.org
>

[Attachment #5 (text/html)]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Thu, Feb 29, 2024 at 4:59 AM Michał Żygowski &lt;<a \
href="mailto:michal.zygowski@3mdeb.com">michal.zygowski@3mdeb.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi folks,<br> <br>
Another leap year, another problem with RTC in firmwares :) This time,<br>
unfortunately, this kind of bugs hit coreboot.<br>
<br>
I have issued a patch that fixes off-by-one error in the days count in<br>
month for a leap year:<br>
<a href="https://review.coreboot.org/c/coreboot/+/80790" rel="noreferrer" \
target="_blank">https://review.coreboot.org/c/coreboot/+/80790</a><br> <br>
It is quite critical, because depending on build date, it may revert to<br>
some very old date, like January 2023 or even older (depending on how<br>
long you run on current firmware). That said, the consequences are<br>
enormous: from false-negative expired certificates, to problems with<br>
filesystems, etc.<br>
<br>
It is worth considering an emergency coreboot release, is it \
not?<br></blockquote><div><br></div><div>I suppose we could CP to the 2402 branch and \
tag a 2402.1 release if there&#39;s sufficient desire for a tagged release with the \
fix</div><div>  </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
Best regards,<br>
<br>
-- <br>
Michał Żygowski<br>
Firmware Engineer<br>
GPG: 6B5BA214D21FCEB2<br>
<a href="https://3mdeb.com" rel="noreferrer" target="_blank">https://3mdeb.com</a> | \
@3mdeb_com<br> _______________________________________________<br>
coreboot mailing list -- <a href="mailto:coreboot@coreboot.org" \
target="_blank">coreboot@coreboot.org</a><br> To unsubscribe send an email to <a \
href="mailto:coreboot-leave@coreboot.org" \
target="_blank">coreboot-leave@coreboot.org</a><br> </blockquote></div></div>



_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-leave@coreboot.org


[prev in list] [next in list] [prev in thread] [next in thread]