[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linuxbios
Subject:    Re: [coreboot] Change in coreboot[master]: dmp/vortex86ex: Initialize I2C controller base address/IR
From:       Andrew Wu <andrewwu.tw () gmail ! com>
Date:       2013-10-28 2:28:46
Message-ID: CANbeq3zsDyxDVbV=SdQcKBCetJpx4RR2t+MKJeM_PhWk-BbMPw () mail ! gmail ! com
[Download RAW message or body]

Hi, Paul, Rudolf,

Thank you for the information. I will investigate this part. :D

Andrew

2013/10/28 Rudolf Marek <r.marek@assembler.cz>:
> Hi,
>
> If Andrew wants to use the fixed address it is better to marked the fixed IO
> address in the I/O allocator as used. Like in VIA vt8237 for ACPI IO base:
>
> static void vt8237r_read_resources(device_t dev)
> {
>         struct resource *res;
>
>         pci_dev_read_resources(dev);
>
>         /* Fixed ACPI Base IO Base*/
>         res = new_resource(dev, 0x88);
>         res->base = VT8237R_ACPI_IO_BASE;
>         res->size = 128;
>         res->limit = 0xffffUL;
>         res->flags = IORESOURCE_IO | IORESOURCE_FIXED | IORESOURCE_RESERVE |
>                      IORESOURCE_STORED | IORESOURCE_ASSIGNED;
> }
>
> But I see this dmp southbrige bypassed the I/O allocator by reserving it
> whole for southbridge.
>
> If no PCI or I/O devices will ever connect this is probably OK, although I
> would prefer to use above construct to add "fixed" I/O resources.
>
> I did not have time to study the code/chipset in the detail, if someone can
> check that it would be great.
>
> Thanks
> Rudolf
>
>
>
>
>
>
> --
> coreboot mailing list: coreboot@coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot

-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
[prev in list] [next in list] [prev in thread] [next in thread]