[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linuxbios
Subject:    Re: [coreboot] [patch] ck804 ACPI PIC/APIC interrupt logic
From:       "Jonathan A. Kollasch" <jakllsch () kollasch ! net>
Date:       2011-05-25 16:59:54
Message-ID: 20110525165954.GS24800 () tarantulon ! kollasch ! net
[Download RAW message or body]

On Mon, May 23, 2011 at 09:53:49PM +0200, Stefan Reinauer wrote:
> * Jonathan A. Kollasch <jakllsch@kollasch.net> [110523 21:28]:
> > Add ACPI automatic PIC/APIC interrupt routing logic for ck804.
> > 
> > Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
> 
> > Index: src/southbridge/nvidia/ck804/acpi/ck804.asl
> > ===================================================================
> > --- src/southbridge/nvidia/ck804/acpi/ck804.asl	(revision 0)
> > +++ src/southbridge/nvidia/ck804/acpi/ck804.asl	(revision 0)
> > @@ -0,0 +1,918 @@
> > +/* For _CRS */
> > +Method (ILM0, 1, Serialized) {
> 
> For Methods the { should be on a new line.
> 
> > +	      If (LEqual (Arg0, 8)) {
> white spaces look messed up

No, that was intentional, i wanted the LEqual to line up,
though then I didn't pad the single character numbers ...

> 
> > +		Return (20)
> > +	} ElseIf (LEqual (Arg0, 13)) {
> > +		Return (21)
> > +	} ElseIf (LEqual (Arg0, 2)) {
> > +		Return (22)
> > +	} ElseIf (LEqual (Arg0, 1)) {
> > +		Return (23)
> > +	} Else {
> > +		Return (0)
> > +	}
> > +}
> > +/* For _SRS */
> > +Method (MLI0, 1, Serialized) {
> > +	      If (LEqual (Arg0, 20)) {
> > +		Return (8)
> 
> ditto

too much indentation inside?

> 
> > +/* For _CRS */
> > +Method (ILM1, 1, Serialized) {
> > +	      If (LEqual (Arg0, 8)) {
> > +		Return (16)
> 
> ... and here
> 
> > +/* For _SRS */
> > +Method (MLI1, 1, Serialized) {
> > +	      If (LEqual (Arg0, 16)) {
> > +		Return (8)
> 
> .. here too.
> 
> > +Device (APIB) {
> > +	Name (_HID, EISAID ("PNP0C0F"))
> 
> Can you call these LNKA/LNKB... we used those names in all other targets
> afaict.

This is intentional, I need a link Device for APIC and PIC for each
device.

	Jonathan Kollasch

-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
[prev in list] [next in list] [prev in thread] [next in thread]