[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linuxbios
Subject:    Re: [coreboot] MP table multicore patch
From:       Myles Watson <mylesgw () gmail ! com>
Date:       2010-02-16 19:42:00
Message-ID: 2831fecf1002161142x666e7884xb7c3e0ae287ef93b () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Tue, Feb 16, 2010 at 12:02 PM, Stefan Reinauer <stepan@coresystems.de>wrote:

> On 2/16/10 5:11 AM, Timothy Pearson wrote:
> > Here is a cleaned up and tested version of the SMP APIC autodetect patch.
> >
> > Signed-off-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
>


> And, can you describe high level, what the patch changes? It looks to me
> as if you are recursing through the tree instead of just walking the
> "all_devices" list.
> So this implies that you don't catch all devices when running through
> all_devices. This sounds like a problem in the resource allocator and
> maybe it should be fixed there instead?
>
I don't understand why this would be a resource allocator problem.  Aren't
we talking about the device tree?

Maybe the real problem is related to the memory corruption seen with printk?

Thanks,
Myles

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Tue, Feb 16, 2010 at 12:02 PM, Stefan Reinauer \
<span dir="ltr">&lt;<a \
href="mailto:stepan@coresystems.de">stepan@coresystems.de</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div><div></div><div \
class="h5">On 2/16/10 5:11 AM, Timothy Pearson wrote:<br> &gt; Here is a cleaned up \
and tested version of the SMP APIC autodetect patch.<br> &gt;<br>
&gt; Signed-off-by: Timothy Pearson &lt;<a \
href="mailto:tpearson@raptorengineeringinc.com">tpearson@raptorengineeringinc.com</a>&gt;</div></div></blockquote><div> \
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">

And, can you describe high level, what the patch changes? It looks to me<br>
as if you are recursing through the tree instead of just walking the<br>
&quot;all_devices&quot; list.<br>
So this implies that you don&#39;t catch all devices when running through<br>
all_devices. This sounds like a problem in the resource allocator and<br>
maybe it should be fixed there instead?<br></blockquote><div>I don&#39;t understand \
why this would be a resource allocator problem.  Aren&#39;t we talking about the \
device tree?<br><br>Maybe the real problem is related to the memory corruption seen \
with printk?<br> <br>Thanks,<br>Myles <br></div></div><br>



-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot

[prev in list] [next in list] [prev in thread] [next in thread]