[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux1394-devel
Subject:    [PATCH 0166/1285] Replace numeric parameter like 0444 with macro
From:       Baole Ni <baolex.ni () intel ! com>
Date:       2016-08-02 10:45:58
Message-ID: 20160802104558.24804-1-baolex.ni () intel ! com
[Download RAW message or body]

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding \
macro, and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/firewire/sbp2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firewire/sbp2.c b/drivers/firewire/sbp2.c
index 6bac039..42f762f 100644
--- a/drivers/firewire/sbp2.c
+++ b/drivers/firewire/sbp2.c
@@ -66,7 +66,7 @@
  * Concurrent logins are useful together with cluster filesystems.
  */
 static bool sbp2_param_exclusive_login = 1;
-module_param_named(exclusive_login, sbp2_param_exclusive_login, bool, 0644);
+module_param_named(exclusive_login, sbp2_param_exclusive_login, bool, S_IRUSR | \
S_IWUSR | S_IRGRP | S_IROTH);  MODULE_PARM_DESC(exclusive_login, "Exclusive login to \
sbp2 device "  "(default = Y, use N for concurrent initiators)");
 
@@ -112,7 +112,7 @@ MODULE_PARM_DESC(exclusive_login, "Exclusive login to sbp2 device \
"  #define SBP2_WORKAROUND_OVERRIDE	0x100
 
 static int sbp2_param_workarounds;
-module_param_named(workarounds, sbp2_param_workarounds, int, 0644);
+module_param_named(workarounds, sbp2_param_workarounds, int, S_IRUSR | S_IWUSR | \
S_IRGRP | S_IROTH);  MODULE_PARM_DESC(workarounds, "Work around device bugs (default \
= 0"  ", 128kB max transfer = " __stringify(SBP2_WORKAROUND_128K_MAX_TRANS)
 	", 36 byte inquiry = "    __stringify(SBP2_WORKAROUND_INQUIRY_36)
-- 
2.9.2


------------------------------------------------------------------------------
_______________________________________________
mailing list linux1394-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux1394-devel


[prev in list] [next in list] [prev in thread] [next in thread]