[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux1394-devel
Subject:    Re: [PATCH] Drivers: firewire: Fixed coding style for all the
From:       Joe Perches <joe () perches ! com>
Date:       2010-08-26 15:41:11
Message-ID: 1282837273.1875.60.camel () Joe-Laptop
[Download RAW message or body]

On Wed, 2010-08-25 at 23:24 +0200, Stefan Richter wrote:
> Rotari Razvan-Gabriel wrote:
[]
> > +++ b/drivers/firewire/core-card.c
> > @@ -107,7 +107,7 @@ static void generate_config_rom(struct fw_card *card, __be32 *config_rom)
> >  	j = 7 + descriptor_count;
> > 
> >  	/* Generate root directory entries for descriptors. */
> > -	list_for_each_entry (desc, &descriptor_list, link) {
> > +	list_for_each_entry(desc, &descriptor_list, link) {
> >  		if (desc->immediate > 0)
> >  			config_rom[i++] = cpu_to_be32(desc->immediate);
> >  		config_rom[i] = cpu_to_be32(desc->key | (j - i));
> 
> Not a fix.

Perhaps you could consider it a consistency change for easier grepping

$ grep -rPoh --include=*.[ch] "\blist_for\w+\s*\(" drivers/firewire | sort | uniq -c
      3 list_for_each_entry (
     21 list_for_each_entry(
     10 list_for_each_entry_safe(




------------------------------------------------------------------------------
Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
Be part of this innovative community and reach millions of netbook users 
worldwide. Take advantage of special opportunities to increase revenue and 
speed time-to-market. Join now, and jumpstart your future.
http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________
mailing list linux1394-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux1394-devel
[prev in list] [next in list] [prev in thread] [next in thread]