[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux1394-devel
Subject:    <linux/wait.h> requires <linux/sched.h> (was Re: [PATCH 3/4]
From:       Stefan Richter <stefanr () s5r6 ! in-berlin ! de>
Date:       2010-02-20 21:24:43
Message-ID: tkrat.5fa896f03c3d0c16 () s5r6 ! in-berlin ! de
[Download RAW message or body]

On 14 Feb, Stefan Richter wrote:
> --- linux-2.6.33-rc8.orig/drivers/firewire/core-cdev.c
> +++ linux-2.6.33-rc8/drivers/firewire/core-cdev.c
[...]
> @@ -32,8 +33,6 @@
>  #include <linux/module.h>
>  #include <linux/mutex.h>
>  #include <linux/poll.h>
> -#include <linux/preempt.h>
> -#include <linux/sched.h>
>  #include <linux/spinlock.h>
>  #include <linux/string.h>
>  #include <linux/time.h>
[...]

This doesn't compile on some configurations.  core-cdev.c requires (and
includes) linux/wait.h which in turn requires (but does not include)
linux/sched.h.

However, adding #include <linux/sched.h> in wait.h isn't going to be
possible very easily; there are a whole lot of missing definitions in
other headers that are pulled in by sched.h then.

Hence I will simply readd sched.h to firewire/core-cdev.c.
-- 
Stefan Richter
-=====-==-=- --=- =-=--
http://arcgraph.de/sr/


------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
mailing list linux1394-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux1394-devel
[prev in list] [next in list] [prev in thread] [next in thread]