[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux1394-devel
Subject:    Re: [PATCH 2/4] firewire: core: rename address handler lookup
From:       Stefan Richter <stefanr () s5r6 ! in-berlin ! de>
Date:       2009-12-15 19:49:17
Message-ID: 4B27E83D.6060302 () s5r6 ! in-berlin ! de
[Download RAW message or body]

Clemens Ladisch wrote:
> Rename the address handler lookup functions for what their purpose is,
> not how they are implemented.

The current names /are/ according to function, not just to implementation.

> This prepares for the following patch which adds more logic to these
> functions.

fw_device matching would change the semantics of the functions indeed.
(But as mentioned in the other reply, fw_device matching is not useful
for existing software and would even be detrimental after patch 4/4.)
-- 
Stefan Richter
-=====-==--= ==-- -====
http://arcgraph.de/sr/

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
mailing list linux1394-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux1394-devel
[prev in list] [next in list] [prev in thread] [next in thread]