[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux1394-devel
Subject:    Re: linux kernel panic when ejecting ieee1394 ipod
From:       Andrew de Quincey <adq_dvb () lidskialf ! net>
Date:       2005-12-08 3:19:19
Message-ID: 200512080319.19434.adq_dvb () lidskialf ! net
[Download RAW message or body]


> [in sbp2_create_command_orb]
>
> > +	/* check for duff DMA transfer direction with a zero length buffer */
> > +	if (scsi_request_bufflen == 0)
> > +		dma_dir = DMA_NONE;
>
> What if you replace WRITE by READ in
> drivers/scsi/scsi_ioctl.c::scsi_cmd_ioctl()::case CDROMEJECT ?

Yup, using READ there fixes it too (and I did remember to remove my other 
patch before testing :)

USB storage devices still work with the CDROMEJECT ioctl and this change as 
well.

> And BTW, can/should this latter case block be converted to use
> scsi_execute() or scsi_execute_req()?

Can't comment - don't know enough about the linux SCSI subsystem.


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
mailing list linux1394-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux1394-devel
[prev in list] [next in list] [prev in thread] [next in thread]