[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux1394-devel
Subject:    Message about PCILynx in kernel config
From:       Jean Delvare <khali () linux-fr ! org>
Date:       2004-01-23 20:05:20
Message-ID: 20040123210520.08108f9f.khali () linux-fr ! org
[Download RAW message or body]

Hi all,

This is a proposed patch to alter the conditions under which the PCILynx
message is displayed while configuring Linux 2.6. The way it is now, a
user with PCI and I2C both disabled will see a message stating that
"PCILynx requires I2C". If the user goes to the I2C section and selects
I2C, then comes back to the IEEE 1394 section, the message will have
disappeared (because I2C isn't missing anymore) but the PCILynx option
will not show (because PCI is still not selected).

I think it might be confusing, so I suggest that the message shouldn't
be displayed at all if PCI isn't selected. And here's a simple patch
that does just this. Built against and tested on Linux 2.6.2-rc1.

Thanks for your attention.

--- linux-2.6.2-rc1/drivers/ieee1394/Kconfig.orig	2004-01-22 10:37:43 +0100
+++ linux-2.6.2-rc1/drivers/ieee1394/Kconfig	2004-01-22 10:43:10 +0100
@@ -52,7 +52,7 @@
 	depends on IEEE1394
 
 comment "Texas Instruments PCILynx requires I2C"
-	depends on IEEE1394 && I2C=n
+	depends on PCI && IEEE1394 && I2C=n
 
 config IEEE1394_PCILYNX
 	tristate "Texas Instruments PCILynx support"


-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
mailing list linux1394-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux1394-devel
[prev in list] [next in list] [prev in thread] [next in thread]