[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-xfs
Subject:    Re: [PATCH 1/5] xfs/276: remove unnecessary mkfs golden output
From:       Brian Foster <bfoster () redhat ! com>
Date:       2021-04-28 17:47:13
Message-ID: YImfodtIxRrG4XAF () bfoster
[Download RAW message or body]

On Tue, Apr 27, 2021 at 09:09:00PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> A previous update to this test dropped the clause where the mkfs
> standard output gets sent to /dev/null.  The filtered mkfs output isn't
> needed here and it breaks the test, so fix that.
> 
> Fixes: e97f96e5 ("xfs/27[26]: force realtime on or off as needed")
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  tests/xfs/276 |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/tests/xfs/276 b/tests/xfs/276
> index 6e2b2fb4..afea48ad 100755
> --- a/tests/xfs/276
> +++ b/tests/xfs/276
> @@ -35,7 +35,7 @@ _require_test_program "punch-alternating"
>  rm -f "$seqres.full"
>  
>  echo "Format and mount"
> -_scratch_mkfs | _filter_mkfs 2> "$tmp.mkfs"
> +_scratch_mkfs | _filter_mkfs 2> "$tmp.mkfs" >/dev/null
>  . $tmp.mkfs
>  cat "$tmp.mkfs" > $seqres.full
>  _scratch_mount
> 

[prev in list] [next in list] [prev in thread] [next in thread]