[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-xfs
Subject:    Re: [PATCH 3/3] metadump: pathname obfuscation overruns symlink buffer
From:       Dave Chinner <david () fromorbit ! com>
Date:       2014-02-28 23:28:16
Message-ID: 20140228232816.GF13647 () dastard
[Download RAW message or body]

On Fri, Feb 28, 2014 at 11:44:11AM -0600, Eric Sandeen wrote:
> On 2/28/14, 12:25 AM, Dave Chinner wrote:
> > diff --git a/db/metadump.c b/db/metadump.c
> > index 3248009..cd489a6 100644
> > --- a/db/metadump.c
> > +++ b/db/metadump.c
> > @@ -1015,16 +1015,23 @@ obfuscate_sf_dir(
> >  	}
> >  }
> >  
> > +/*
> > + * The pathname may not be null terminated. It name be terminated by the end of
> 
> can you fix up the start of that 2nd sentence?

Done.

> 
> Otherwise,
> 
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>

Thanks!

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
[prev in list] [next in list] [prev in thread] [next in thread]