[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-xfs
Subject: Re: [PATCH 4/8] xfs: clean up buffer get/read call API
From: Mark Tinguely <tinguely () sgi ! com>
Date: 2012-03-30 19:12:10
Message-ID: 4F76058A.2010602 () sgi ! com
[Download RAW message or body]
On 03/29/12 07:23, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> The xfs_buf_get/read API is not consistent in the units it uses, and
> does not use appropriate or consistent units/types for the
> variables.
>
> Convert the API to use disk addresses and block counts for all
> buffer get and read calls. Use consistent naming for all the
> functions and their declarations, and convert the internal functions
> to use disk addresses and block counts to avoid need to convert them
> from one type to another and back again.
>
> Fix all the callers to use disk addresses and block counts. In many
> cases, this removes an additional conversion from the function call
> as the callers already have a block count.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig<hch@lst.de>
> ---
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic