[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-xfs
Subject: Re: [PATCH 2/2] xfs: fix ->write_inode return values
From: Dave Chinner <david () fromorbit ! com>
Date: 2011-08-30 6:25:32
Message-ID: 20110830062532.GO3162 () dastard
[Download RAW message or body]
On Sat, Aug 27, 2011 at 01:57:55AM -0400, Christoph Hellwig wrote:
> Currently we always redirty an inode that was attempted to be written out
> synchronously but has been cleaned by an AIL pushed internall, which is
> rather bogus. Fix that by doing the i_update_core check early on and
> return 0 for it. Also include async calls for it, as doing any work for
> those is just as pointless. While we're at it also fix the sign for the
> EIO return in case of a filesystem shutdown, and fix the completely
> non-sensical locking around xfs_log_inode.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Makes sense.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic