[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-xfs
Subject:    Re: [PATCH] Fix non-debug build for xfsidbg.c
From:       Lachlan McIlroy <lachlan () sgi ! com>
Date:       2008-04-30 7:17:24
Message-ID: 48181D04.4030902 () sgi ! com
[Download RAW message or body]

Dave, would the code look cleaner if iclog_bak was printed on a line by itself?
That way we wouldn't need the #else and we wouldn't be duplicating code.

David Chinner wrote:
> Make the use of l_iclog_bak conditional on debug configs.
> 
> Signed-off-by: Dave Chinner <dgc@sgi.com>
> ---
>  fs/xfs/xfsidbg.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> Index: 2.6.x-xfs-new/fs/xfs/xfsidbg.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/xfsidbg.c	2008-04-30 16:47:06.000000000 +1000
> +++ 2.6.x-xfs-new/fs/xfs/xfsidbg.c	2008-04-30 16:49:33.615164895 +1000
> @@ -5845,9 +5845,14 @@ xfsidbg_xlog(xlog_t *log)
>  	kdb_printf("curr_cycle: %d  prev_cycle: %d  curr_block: %d  prev_block: %d\n",
>  	     log->l_curr_cycle, log->l_prev_cycle, log->l_curr_block,
>  	     log->l_prev_block);
> +#ifdef DEBUG
>  	kdb_printf("iclog_bak: 0x%p  iclog_size: 0x%x (%d)  num iclogs: %d\n",
>  		log->l_iclog_bak, log->l_iclog_size, log->l_iclog_size,
>  		log->l_iclog_bufs);
> +#else
> +	kdb_printf("iclog_size: 0x%x (%d)  num iclogs: %d\n",
> +		log->l_iclog_size, log->l_iclog_size, log->l_iclog_bufs);
> +#endif
>  	kdb_printf("l_iclog_hsize %d l_iclog_heads %d\n",
>  		log->l_iclog_hsize, log->l_iclog_heads);
>  	kdb_printf("l_sectbb_log %u l_sectbb_mask %u\n",
> 


[prev in list] [next in list] [prev in thread] [next in thread]