[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-xfs
Subject:    Re: review: don't hold ilock when calling vn_iowait
From:       Christoph Hellwig <hch () infradead ! org>
Date:       2007-04-24 9:10:00
Message-ID: 20070424091000.GA31652 () infradead ! org
[Download RAW message or body]

On Tue, Apr 24, 2007 at 01:08:26PM +1000, David Chinner wrote:
> > It would be nice if this could be clearer somehow.
> 
> Yes, we should be looking to rip all this cruft out because most of
> it is redundant - the generic inode writeback does most of this
> for us anyway.

In theory it does the same thing.  The problem is that it's really
hard to verify.

Btw, before starting with this bit there's another item on my TODO
list to simplify xfs_sync_inodes, and that's getting rid
of the vp == NULL case totally.  Per definition all vp == NULL
inodes are on mp->m_del_inodes.  So instead of letting xfs_sync_inodes
deals with them we should always call into xfs_finish_reclaim_all
after cleaning the latter up a little and veryfing we get
the same behaviour.


[prev in list] [next in list] [prev in thread] [next in thread]