[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-wpan
Subject:    Re: [RFC net-next] net: Z-Wave driver prototype
From:       Andreas_Färber <afaerber () suse ! de>
Date:       2019-01-20 20:26:08
Message-ID: 653e10b5-ff5f-dafc-6a4f-1569883fb68b () suse ! de
[Download RAW message or body]

Hi,

Am 20.01.19 um 19:56 schrieb Randy Dunlap:
> On 1/20/19 10:33 AM, Andreas Färber wrote:
> > Tested as external kernel module, so Kconfig/Makefile integration missing.
[...]
> > diff --git a/drivers/net/zwave/Makefile b/drivers/net/zwave/Makefile
> > new file mode 100644
> > index 000000000000..1a4171308c79
> > --- /dev/null
> > +++ b/drivers/net/zwave/Makefile
> > @@ -0,0 +1 @@
> > +obj-m += zwave.o
> 
> This will need a Kconfig file and a symbol so that the Makefile
> will not always build the zwave module.

Well, as I noted in the commit message you cut off, this Makefile is not
included from drivers/net/. So it should actually not get built at all,
unless you build it explicitly as module:

$ make -C /lib/modules/`uname -r`/build M=$PWD/drivers/net/zwave

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/modules.txt?id=HEAD


This RFC is nowhere near merging, so there's no point in bike-shedding
about Kconfig help texts. The Kconfig/Makefile integration depends on
the alternatives outlined in the commit message of what to make of this.
Right now it does not expose any netdev nor any other useful interfaces,
merely demonstrating that via serdev it could be handled in the kernel.

The big context here is RF ASICs vs. SDR and the layering of PHY and MAC
implementations and their user-facing (socket) interfaces. Cf. slide 24:
https://events.linuxfoundation.org/wp-content/uploads/2017/12/ELCE2018_LoRa_final_Andreas-Farber.pdf
 (Z-Wave was marked in orange as not-entirely-open protocol over FSK.)

I had this Z-Wave module lying around, so I gave it a quick shot to get
a feeling for the protocol in comparison. If no one finds the RFC useful
then it can die as quickly as it came to life. :)

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)


[prev in list] [next in list] [prev in thread] [next in thread]