[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-wlan-devel
Subject:    [lwlan-devel] [PATCH] Fix for versioning warnings
From:       Pavel Roskin <proski () gnu ! org>
Date:       2005-01-26 23:13:47
Message-ID: Pine.LNX.4.62.0501261737250.14589 () localhost ! localdomain
[Download RAW message or body]

Hello!

The resent changes in the makefiles made the versioning warnings reappear:

*** Warning: "register_wlandev" 
[/usr/local/src/lwlan/src/prism2/driver/prism2_cs.ko] undefined!
*** Warning: "wlan_setup" 
[/usr/local/src/lwlan/src/prism2/driver/prism2_cs.ko] undefined!
*** Warning: "wlan_unsetup" 
[/usr/local/src/lwlan/src/prism2/driver/prism2_cs.ko] undefined!
...

When the M variable is used to build modules, .tmp_versions is created in 
the current directory.  The result is that the build process in 
src/prism2/driver/Makefile doesn't see the symbols exported by the p80211 
module.

I checked the kernel top-level Makefile and found that .tmp_versions is 
created in the first directory specified in the M variable.  That would be 
$(WLAN_SRC).  Strictly speaking, it would be the corresponding 
build directory.  Not sure if building outside the source tree is 
supported, but since such distinction exists, I'll preserve it.

Adding $(WLAN_SRC) to the M variable should be OK since the Makefile there 
doesn't specify any modules.  The actual modules are still created where 
their sources are, so "make install" still works.

Also, src/p80211/Makefile doesn't need to do anything with .tmp_versions 
and Module.symvers, so I'm removing that code.

-- 
Regards,
Pavel Roskin
["tmp_versions.diff" (TEXT/PLAIN)]

Index: src/p80211/Makefile
===================================================================
--- src/p80211/Makefile	(revision 1679)
+++ src/p80211/Makefile	(working copy)
@@ -74,15 +74,7 @@
 default:
 
 ifeq ($(KERN_25), y)
-	if test ! -d $(WLAN_SRC)/.tmp_versions; then \
-		if test -d $(LINUX_SRC)/.tmp_versions; then \
-			cp -rf $(LINUX_SRC)/.tmp_versions $(PWD)/../ ; \
-		fi ; \
-	fi
-	if test ! -e $(WLAN_SRC)/Module.symvers ; then \
-		cp $(LINUX_SRC)/Module.symvers $(WLAN_SRC) ; \
-	fi
-	$(MAKE) -C $(LINUX_SRC) M=$(PWD) WLAN_SRC=$(WLAN_SRC) modules
+	$(MAKE) -C $(LINUX_SRC) M='$(PWD)/.. $(PWD)' WLAN_SRC=$(WLAN_SRC) modules
 else
 	$(MAKE) -C $(LINUX_SRC) SUBDIRS=$(PWD) WLAN_SRC=$(WLAN_SRC) dep modules
 endif # KERN_25
Index: src/prism2/driver/Makefile
===================================================================
--- src/prism2/driver/Makefile	(revision 1679)
+++ src/prism2/driver/Makefile	(working copy)
@@ -84,7 +84,7 @@
 
 default:
 ifeq ($(KERN_25), y)
-	$(MAKE) -C $(LINUX_SRC) M=$(PWD) WLAN_SRC=$(WLAN_SRC) \
+	$(MAKE) -C $(LINUX_SRC) M='$(PWD)/../.. $(PWD)' WLAN_SRC=$(WLAN_SRC) \
 		modules
 else # kbuild 2.4
 	$(MAKE) -C $(LINUX_SRC) SUBDIRS=$(PWD) WLAN_SRC=$(WLAN_SRC) \


_______________________________________________
Linux-wlan-devel mailing list
Linux-wlan-devel@lists.linux-wlan.com
http://lists.linux-wlan.com/mailman/listinfo/linux-wlan-devel


[prev in list] [next in list] [prev in thread] [next in thread]