[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-wireless
Subject:    Re: [v2] wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()
From:       Kalle Valo <kvalo () kernel ! org>
Date:       2023-03-31 14:53:19
Message-ID: 168027439802.32751.12727089467874347568.kvalo () kernel ! org
[Download RAW message or body]

Wei Chen <harperchen1110@gmail.com> wrote:

> If there is a failure during copy_from_user or user-provided data buffer is
> invalid, rtl_debugfs_set_write_reg should return negative error code instead
> of a positive value count.
> 
> Fix this bug by returning correct error code. Moreover, the check of buffer
> against null is removed since it will be handled by copy_from_user.
> 
> Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
> Signed-off-by: Wei Chen <harperchen1110@gmail.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

Patch applied to wireless-next.git, thanks.

5dbe1f8eb8c5 wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230326054217.93492-1-harperchen1110@gmail.com/


https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


[prev in list] [next in list] [prev in thread] [next in thread]