[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-wireless
Subject:    Re: [PATCH] rtlwifi: Fix fallback firmware loading
From:       Larry Finger <Larry.Finger () lwfinger ! net>
Date:       2017-07-30 23:57:57
Message-ID: d1c1790d-015d-4dae-8532-42701737eea3 () lwfinger ! net
[Download RAW message or body]

On 07/29/2017 04:21 AM, Sven Joachim wrote:
> Commit f70e4df2 ("rtlwifi: Add code to read new versions of firmware")
> added code to load an old firmware file if the new one is not
> available.  Unfortunately that code is never reached because
> request_firmware_nowait() does not wait for the firmware to show up
> and returns 0 even if the file is not there.
> 
> Use the existing fallback mechanism introduced by commit
> 62009b7f ("rtlwifi: rtl8192cu: Add new firmware") instead.
> 
> Fixes: f70e4df2b384d21e36a7c30a591639592692e0ec
> Cc: stable@vger.kernel.org
> Signed-off-by: Sven Joachim <svenjoac@gmx.de>

Your solution seems to be correct; however, your patch fails to apply. Make 
certain that you have the latest pull on the wireless-drivers-next repo. In 
particular, it needs commit f2764f61fa105 by Souptik Jarder, which changed the 
error return.

NACK.

Larry
[prev in list] [next in list] [prev in thread] [next in thread]