[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-wireless
Subject:    Re: [PATCH] introduce WEXT scan capabilities
From:       drago01 <drago01 () gmail ! com>
Date:       2007-12-08 10:56:46
Message-ID: 475A786E.60200 () gmail ! com
[Download RAW message or body]

David Miller wrote:
> From: Dan Williams <dcbw@redhat.com>
> Date: Fri, 07 Dec 2007 19:22:46 -0500
>
>   
>> @@ -1040,6 +1049,16 @@ struct	iw_range
>>  	 * because each entry contain its channel index */
>>  
>>  	__u32		enc_capa;	/* IW_ENC_CAPA_* bit field */
>> +
>> +	/* Do *NOT* use those fields, they are just used as padding to get
>> +	 * proper alignement with user space */
>> +	__s32		reserved1;
>> +	__s32		reserved2;
>> +	__u16		reserved3;
>> +	__s32		reserved4;
>> +	__u32		reserved5;
>> +
>> +	__u32		scan_capa;	/* IW_SCAN_CAPA_* bit field */
>>  };
>>  
>>  /*
>>     
>
> Major NACK.  These datastructure usages are complete wrong, and
> we have to stop spreading this problem instead of continuing on
> with it as if it's OK.
>   
But it seems like we have to deal with this api until nl80211/cfg80211 
is ready. But the situation is _worse_ without this patch (hidden ssid 
support is a huge mess).
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]