[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-virtualization
Subject:    Re: [PATCH v2 4/6] dt-bindings: hypervisor: Rename virtio to hypervisor
From:       Rob Herring <robh () kernel ! org>
Date:       2023-01-31 19:57:36
Message-ID: 167519443459.1836211.1945655170442861713.robh () kernel ! org
[Download RAW message or body]


On Tue, 31 Jan 2023 10:10:07 -0800, Saurabh Sengar wrote:
> Rename virtio folder to more generic hypervisor, so that this can
> accommodate more devices of similar type.
> 
> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> ---
> .../devicetree/bindings/{virtio => hypervisor}/mmio.yaml        | 2 +-
> .../devicetree/bindings/{virtio => hypervisor}/pci-iommu.yaml   | 2 +-
> .../bindings/{virtio => hypervisor}/virtio-device.yaml          | 2 +-
> MAINTAINERS                                                     | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
> rename Documentation/devicetree/bindings/{virtio => hypervisor}/mmio.yaml (95%)
> rename Documentation/devicetree/bindings/{virtio => hypervisor}/pci-iommu.yaml \
> (98%) rename Documentation/devicetree/bindings/{virtio => \
> hypervisor}/virtio-device.yaml (93%) 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/i2c/i2c-virtio.yaml: Unable to find schema file \
                matching $id: http://devicetree.org/schemas/virtio/virtio-device.yaml
./Documentation/devicetree/bindings/gpio/gpio-virtio.yaml: Unable to find schema file \
                matching $id: http://devicetree.org/schemas/virtio/virtio-device.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/i2c-virtio.example.dtb: \
i2c: False schema does not allow {'compatible': ['virtio,device22'], \
'#address-cells': [[1]], '#size-cells': [[0]], 'light-sensor@20': {'compatible': \
['dynaimage,al3320a'], 'reg': [[32]]}, '$nodename': ['i2c']}  From schema: \
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/i2c-virtio.yaml
                
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/gpio/gpio-virtio.example.dtb: \
gpio: False schema does not allow {'compatible': ['virtio,device29'], \
'gpio-controller': True, '#gpio-cells': [[2]], 'interrupt-controller': True, \
'#interrupt-cells': [[2]], '$nodename': ['gpio']}  From schema: \
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
                
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hypervisor/virtio-device.example.dtb: \
i2c: False schema does not allow {'compatible': ['virtio,device22'], '$nodename': \
['i2c']}  From schema: \
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/i2c-virtio.yaml


doc reference errors (make refcheckdocs):
MAINTAINERS: Documentation/devicetree/bindings/virtio/

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1675188609-20913-5-git-send-email-ssengar@linux.microsoft.com


The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization


[prev in list] [next in list] [prev in thread] [next in thread]