[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-virtualization
Subject: Re: [PATCH v3 0/1] virtio_bt: Fix alignment in configuration struct
From: "Michael S. Tsirkin" <mst () redhat ! com>
Date: 2022-10-25 3:58:48
Message-ID: 20221025000433-mutt-send-email-mst () kernel ! org
[Download RAW message or body]
On Mon, Oct 24, 2022 at 03:40:32PM +0200, Igor Skalkin wrote:
> According to specification [1], "For the device-specific configuration
> space, the driver MUST use 8 bit wide accesses for 8 bit wide fields,
> 16 bit wide and aligned accesses for 16 bit wide fields and 32 bit wide
> and aligned accesses for 32 and 64 bit wide fields.".
>
> Current version of the configuration structure has non-aligned 16bit
> fields.
>
> This patch adds a second, aligned version of the configuration structure
> and a new feature bit indicating that this version is being used.
subject should be v4 but besides that, ok.
Will a spec patch be forthcoming?
> [1] https://docs.oasis-open.org/virtio/virtio/v1.1/virtio-v1.1.pdf
>
> Changes in v4:
> v3 was corrupted by our smtp server.
> Changes in v3:
> v2 had been sent from the wrong address, fixed.
> Changes in v2:
> The first version of this patch just changed the configuration
> structure in uapi/linux/virtio_bt.h
> This can not be done, because it will break the userspace, so the
> second version offers a less radical approach - it introduces a new
> feature bit and a new configuration structure that both the device
> and the driver will use if this bit is negotiated.
>
> Igor Skalkin (1):
> virtio_bt: Fix alignment in configuration struct
>
> drivers/bluetooth/virtio_bt.c | 16 +++++++++++++---
> include/uapi/linux/virtio_bt.h | 8 ++++++++
> 2 files changed, 21 insertions(+), 3 deletions(-)
>
> --
> 2.37.2
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic