[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-video
Subject:    Odd I2c gate code in tda1004x.c
From:       Hartmut Hackmann <hartmut.hackmann () t-online ! de>
Date:       2006-10-04 21:28:22
Message-ID: 45242776.3050703 () t-online ! de
[Download RAW message or body]

Hi,

I stumbled over some strange code in the tda1004x_set_fe()
function. It calls the set_params() function without
opening the gate before but afterwards it closes it.
So
- the set_params() function needs to open the gate before
   it accesses the tuner, but it doesn't need to close it.
- _init and _sleep need to do both.

This is confusing. Is there a reason why it is this way?
I would prefer either to completely control the gate
in the  tda1004x_set_fe() function or completely leave
it to the board specific code.

Comments?

Best regards
    Hartmut

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
[prev in list] [next in list] [prev in thread] [next in thread]