[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-video
Subject:    Re: [Patch] Adding support for the Hauppage HVR1100
From:       Unai Garro <ugarro () telefonica ! net>
Date:       2005-11-30 18:19:10
Message-ID: 200511301919.11054.ugarro () telefonica ! net
[Download RAW message or body]

Thanks a lot, Steve. Just dropping a note to let you know that the patch works 
just fine here.

Best regards,

	Unai

On Wednesday 30 November 2005 06:03, Steve Toth wrote:
> >> Yes. More difficult. I can pollute tuner.ko with cx88 stuff, and have
> >> the specific 'gate' flag passed in tuner_setup, or added to cx88_core,
> >> but it didn't seem to make any sense when tuner.ko only knows about I2C
> >> clients and tuner types (not demods and specific demod behavior, or even
> >> DVB related things for that matter).
> >
> > No, we shouldn't add cx88 specific stuff to tuner.ko, but in
> > cx88 where the VIDIOC_S_FREQUENCY ioctl is processed you should be able
> > to open the i2c gate before cx88_call_i2c_clients(), no?
>
> I was trying to avoid any changes outside of cx88_dvb.ko --  It was
> probably unavoidable.
>
> A patch is attached for review.
>
> Here's a summary:
> 1. The cx22702 driver has two exported functions to open/close the
> plli2c on demand.
> 2. cx88_dvb.ko has two new functions which call the demod plli2c
> open/close exports driven by board type.
> 3. cx8800.ko (via the V4L ioctls) calls cx88_dvb-enable/disable when
> using cx88_call_i2c_clients, you will see this repeated everywhere
> throughout the module. (I tried moving the enable/disable into the
> actual cx88_call_i2c_clients function but ended up with circular depmod
> references in most of the cx88 modules. I can look into this tomorrow).
>
> Apart from that, we hold a reference to the cx8802_dev struct in
> cx88_core else cx88-video has no way to find the original dvb_frontend
> structure. cx88_dvb will also become a module dependency of cx8800.
>
> The patch is working here but looks (temporarily) ugly inside cx8800.ko.
> More cleanup is required.
>
> Comments/feedback welcome.
>
> Steve

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
[prev in list] [next in list] [prev in thread] [next in thread]