[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb-devel
Subject:    Re: [linux-usb-devel] [PATCH 0/3] ehci-hcd: complete iso urbs
From:       David Brownell <david-b () pacbell ! net>
Date:       2007-12-31 7:33:25
Message-ID: 200712302333.25819.david-b () pacbell ! net
[Download RAW message or body]

On Tuesday 13 November 2007, Karsten Wiese wrote:
> Hi David!
> 
> Differences in this version:
> 
> In patch 1:
> - itd_complete() split into 3 functions, assures schedule is updated
>   before ITD is recycled and lets
> - updates to ehci->periodic_sched happen per urb again
> - SITD handling unchanged. Didn't find anything to improve.

I've been looking that over, and not liking the complexity.
Seems to me a far simpler patch should solve this.  I'll
post it in a minute.


> New patches 2 & 3
> - Reduce dma-memory usage by slimming struct ehci_itd.
>   On x86_64 patch 1 makes ehci_itd grow 1 32byte alignment step,
>   patch 2 & 3 let ehci_itd take 1 32byte alignment less each.

These are nice.  I never liked how bloated the ITD structure
had gotten.  :)

I already signed off on an updated version of #3 ... I'll split
out the fix in #2 from your patch #2 and send it along too.

-  Dave

p.s. further traffic to linux-usb@vger ...

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
[prev in list] [next in list] [prev in thread] [next in thread]