[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb-devel
Subject:    Re: [linux-usb-devel] [PATCH] bugfix for usb core
From:       Randy Dunlap <rdunlap () xenotime ! net>
Date:       2007-08-30 14:55:42
Message-ID: 20070830075542.5fce1d86.rdunlap () xenotime ! net
[Download RAW message or body]

On Thu, 30 Aug 2007 13:56:23 +0200 Nathael Pajani wrote:

> Hi!
> 
> I already wrote for a bugfix in the past (kernel 2.6.20), and I just found the 
> bug back in the 2.6.22.5 !
> I should have used a beter insecticide :)
> (Or maybe I'm doing a mistake, but I don't think so)
> 
> The bug is about linked list use in drivers/usb/core/driver.c (see attached 
> patch linked_list_insersion_bugfix.patch)

Please describe the problem that the patch fixes.

Don't use attachments if you can instead insert the patch into the
body of the email.  Tbird can do this by using an external editor,
or you can try the hints at
http://mbligh.org/linuxdocs/Email/Clients/Thunderbird

Use regular kernel coding style, not your own.  That means this:

-	list_add_tail(&dynids->list, &dynid->node);
+	list_add_tail( &dynid->node, &dynids->list );

should keep the same parentheses/spacing that the old line has.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
[prev in list] [next in list] [prev in thread] [next in thread]