[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb-devel
Subject:    Re: [linux-usb-devel] autosuspend for HID devices, take #5
From:       Oliver Neukum <oneukum () suse ! de>
Date:       2007-05-30 18:30:51
Message-ID: 200705302030.52059.oneukum () suse ! de
[Download RAW message or body]

Am Mittwoch, 30. Mai 2007 17:25 schrieb Jiri Kosina:
> On Wed, 23 May 2007, Oliver Neukum wrote:
> 
> >  	del_timer_sync(&usbhid->io_retry);
> > +	cancel_work_sync(&usbhid->restart_work);
> >  	flush_scheduled_work();
> 
> Hi Oliver,
> 
> isn't the call to flush_scheduled_work() after cancel_work_sync() 
> redundant?
> 
> Also, we could very probably use the hotplug-safer cancel_work_sync() 
> elsewhere in your patch where you introduce flush_scheduled_work(), right?

Alan's last mail has addressed the issue.

	Regards
		Oliver

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
[prev in list] [next in list] [prev in thread] [next in thread]