[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb-devel
Subject:    Re: [linux-usb-devel] [PATCH as428] Hub driver: several bug fixes and simplifications
From:       Oliver Neukum <oliver () neukum ! org>
Date:       2004-11-29 20:09:08
Message-ID: 200411292109.09232.oliver () neukum ! org
[Download RAW message or body]

Am Montag, 29. November 2004 19:07 schrieb Alan Stern:> On Mon, 29 Nov 2004, Oliver \
Neukum wrote:> > > Am Montag, 29. November 2004 18:20 schrieb Alan Stern:> > +> > +   \
/* don't allow the user to unbind the hub driver from> > +                * a hub \
with children to manage */> > +               for (i = 0; i < ps->dev->maxchild; ++i) \
{> > +                       if (ps->dev->children[i])> > +                           \
retval = -EBUSY;> > +               }> > +               if (retval)> > +             \
break;> > +> > > > Are you sure locking is sufficient here?> > Yes.  This code \
executes with ps->dev locked, and the children[] array    > isn't changed without \
holding the device lock. OK, I see.
	Regards		Oliver隊X'uNLv-y \
v'zq݉޾'wky(|Ϯnryn8rޯbrkۜk\-rҵ杊x' \
kۜufj:.v&)o^+- \
(~{޵:.˛mazV+֭mXy+zlX)ߣbu


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic