[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-usb
Subject: Re: [PATCH v7 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings
From: Rob Herring <robh () kernel ! org>
Date: 2022-05-31 22:46:54
Message-ID: 1654037214.496823.2476575.nullmailer () robh ! at ! kernel ! org
[Download RAW message or body]
On Tue, 31 May 2022 21:44:51 +0530, Krishna Kurapati wrote:
> From: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>
> Add device tree bindings for SNPS phy tuning parameters.
>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 96 ++++++++++++++++++++++
> 1 file changed, 96 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,squelch-detector-bp: 'oneOf' conditional failed, one must be fixed: \
'type' is a required property hint: A vendor boolean property can use "type: \
boolean" Additional properties are not allowed ('maximum', 'minimum' were \
unexpected) hint: A vendor boolean property can use "type: boolean"
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,squelch-detector-bp: 'oneOf' conditional failed, one must be fixed: \
'enum' is a required property 'const' is a required property
hint: A vendor string property with exact values has an implicit type
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,squelch-detector-bp: 'oneOf' conditional failed, one must be fixed: \
'$ref' is a required property 'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
hint: Vendor specific properties must have a type and description unless they have a \
defined, common suffix. from schema $id: \
http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,ls-fs-output-impedance-bp: 'oneOf' conditional failed, one must be \
fixed: 'type' is a required property
hint: A vendor boolean property can use "type: boolean"
Additional properties are not allowed ('maximum', 'minimum' were unexpected)
hint: A vendor boolean property can use "type: boolean"
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,ls-fs-output-impedance-bp: 'oneOf' conditional failed, one must be \
fixed: 'enum' is a required property
'const' is a required property
hint: A vendor string property with exact values has an implicit type
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,ls-fs-output-impedance-bp: 'oneOf' conditional failed, one must be \
fixed: '$ref' is a required property
'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
hint: Vendor specific properties must have a type and description unless they have a \
defined, common suffix. from schema $id: \
http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,hs-amplitude-bp: 'oneOf' conditional failed, one must be fixed: \
'type' is a required property hint: A vendor boolean property can use "type: \
boolean" Additional properties are not allowed ('maximum', 'minimum' were \
unexpected) hint: A vendor boolean property can use "type: boolean"
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,hs-amplitude-bp: 'oneOf' conditional failed, one must be fixed: \
'enum' is a required property 'const' is a required property
hint: A vendor string property with exact values has an implicit type
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,hs-amplitude-bp: 'oneOf' conditional failed, one must be fixed: \
'$ref' is a required property 'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
hint: Vendor specific properties must have a type and description unless they have a \
defined, common suffix. from schema $id: \
http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,pre-emphasis-duration-bp: 'oneOf' conditional failed, one must be \
fixed: 'type' is a required property
hint: A vendor boolean property can use "type: boolean"
Additional properties are not allowed ('maximum', 'minimum' were unexpected)
hint: A vendor boolean property can use "type: boolean"
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,pre-emphasis-duration-bp: 'oneOf' conditional failed, one must be \
fixed: 'enum' is a required property
'const' is a required property
hint: A vendor string property with exact values has an implicit type
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,pre-emphasis-duration-bp: 'oneOf' conditional failed, one must be \
fixed: '$ref' is a required property
'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
hint: Vendor specific properties must have a type and description unless they have a \
defined, common suffix. from schema $id: \
http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,pre-emphasis-amplitude-bp: 'oneOf' conditional failed, one must be \
fixed: 'type' is a required property
hint: A vendor boolean property can use "type: boolean"
Additional properties are not allowed ('maximum', 'minimum' were unexpected)
hint: A vendor boolean property can use "type: boolean"
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,pre-emphasis-amplitude-bp: 'oneOf' conditional failed, one must be \
fixed: 'enum' is a required property
'const' is a required property
hint: A vendor string property with exact values has an implicit type
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,pre-emphasis-amplitude-bp: 'oneOf' conditional failed, one must be \
fixed: '$ref' is a required property
'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
hint: Vendor specific properties must have a type and description unless they have a \
defined, common suffix. from schema $id: \
http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,hs-disconnect-bp: 'oneOf' conditional failed, one must be fixed: \
'type' is a required property hint: A vendor boolean property can use "type: \
boolean" Additional properties are not allowed ('maximum', 'minimum' were \
unexpected) hint: A vendor boolean property can use "type: boolean"
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,hs-disconnect-bp: 'oneOf' conditional failed, one must be fixed: \
'enum' is a required property 'const' is a required property
hint: A vendor string property with exact values has an implicit type
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,hs-disconnect-bp: 'oneOf' conditional failed, one must be fixed: \
'$ref' is a required property 'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
hint: Vendor specific properties must have a type and description unless they have a \
defined, common suffix. from schema $id: \
http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,hs-rise-fall-time-bp: 'oneOf' conditional failed, one must be fixed: \
'type' is a required property hint: A vendor boolean property can use "type: \
boolean" Additional properties are not allowed ('maximum', 'minimum' were \
unexpected) hint: A vendor boolean property can use "type: boolean"
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,hs-rise-fall-time-bp: 'oneOf' conditional failed, one must be fixed: \
'enum' is a required property 'const' is a required property
hint: A vendor string property with exact values has an implicit type
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
properties:qcom,hs-rise-fall-time-bp: 'oneOf' conditional failed, one must be fixed: \
'$ref' is a required property 'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
hint: Vendor specific properties must have a type and description unless they have a \
defined, common suffix. from schema $id: \
http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: \
ignoring, error in schema: properties: qcom,hs-rise-fall-time-bp \
Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dtb:0:0: \
/example-0/phy@88e2000: failed to match any schema with compatible: \
['qcom,sm8150-usb-hs-phy']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic