[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb
Subject:    [PATCH 1/2 ] cdc_ncm: Handle multicast Ethernet traffic
From:       Miguel_Rodríguez_Pérez <miguel () det ! uvigo ! gal>
Date:       2018-06-30 14:24:35
Message-ID: 3ad90982-414d-108f-304e-e22ae7df9748 () det ! uvigo ! gal
[Download RAW message or body]

There is nothing wrong with it, but there was no way cdc_ncm driver
could use it, as it currently overwrites the struct net_device_ops, so
the usbnet function set_rx_mode was not ever getting called.

This patch restores the right behavior, so that usbnet's set _rx_mode
gets called again for cdn_ncm devices. The second patch (the one with
the wrong subject) hooks into set_rx_mode to accept multicast traffic
when asked to do so.

Regards.

On 29/06/18 22:37, Oliver Neukum wrote:
> On Fr, 2018-06-29 at 16:45 +0200, Miguel Rodríguez Pérez  wrote:
>> Subject: [PATCH 1/2] Hook into usbnet_change_mtu respecting usbnet
>> driver_info
>>
>> Change the way cdc_ncm_change_mtu hooks into the netdev_ops
>> structure so that changes into usbnet driver_info operations
>> can be respected. Without this, is was not possible to hook
>> into usbnet_set_rx_mode.
> 
> Hi,
> 
> what is wrong with the existing hook?
> 
> static void __handle_set_rx_mode(struct usbnet *dev)
> {
>         if (dev->driver_info->set_rx_mode)
>                 (dev->driver_info->set_rx_mode)(dev);
> 
>         clear_bit(EVENT_SET_RX_MODE, &dev->flags);
> }
> 
> If you cannot use it, I would prefer you to actually fix that.
> 
> 	Regards
> 		Oliver
> 

-- 
Miguel Rodríguez Pérez
Laboratorio de Redes
EE Telecomunicación – Universidade de Vigo

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]