[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb
Subject:    Re: [PATCH] gadget: Fix a sleep-in-atomic bug
From:       Michal Nazarewicz <mina86 () mina86 ! com>
Date:       2017-05-31 10:57:33
Message-ID: xa1tefv5qoo2.fsf () mina86 ! com
[Download RAW message or body]

On Wed, May 31 2017, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> ffs_epfile_io (acquire the lock by spin_lock_irq)
>   usb_ep_alloc_request(GFP_KERNEL) --> may sleep
>
> To fix it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC".
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> ---
>  drivers/usb/gadget/function/f_fs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
> index 47dda34..be90e25 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -1015,7 +1015,7 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data)
>  		else
>  			ret = ep->status;
>  		goto error_mutex;
> -	} else if (!(req = usb_ep_alloc_request(ep->ep, GFP_KERNEL))) {
> +	} else if (!(req = usb_ep_alloc_request(ep->ep, GFP_ATOMIC))) {
>  		ret = -ENOMEM;
>  	} else {
>  		req->buf      = data;

-- 
Best regards
γƒŸγƒγ‚¦ "𝓢𝓲𝓷π“ͺ86" γƒŠγ‚Άγƒ¬γƒ΄γ‚€γƒ„
 «If at first you don't succeed, give up skydiving »
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]