[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb
Subject:    Re: [PATCH v2] storage: accept some UAS devices if streams are unavailable
From:       Sarah Sharp <sarah.a.sharp () linux ! intel ! com>
Date:       2014-02-28 21:16:26
Message-ID: 20140228211626.GB5340 () xanatos
[Download RAW message or body]

On Mon, Feb 24, 2014 at 04:00:37PM +0100, Oliver Neukum wrote:
> On Fri, 2014-02-21 at 15:00 -0800, Sarah Sharp wrote:
> > On Tue, Feb 11, 2014 at 08:36:04PM +0100, oliver@neukum.org wrote:
> > > From: Oliver Neukum <oneukum@suse.de>
> > > 
> > > On some older XHCIs streams are not supported and the UAS driver
> > > will fail at probe time. For those devices storage should try
> > > to bind to UAS devices.
> > > This patch adds a flag for stream support to HCDs and evaluates
> > > it.
> > 
> > Oliver, the logic in this patch is off.  When I plug it into an Intel
> > Panther Point xHCI host that has hcc_params set to 0x20007181, which
> > translates to 2^(7+1) stream IDs, the device comes up as usb-storage,
> > not uas:
> 
> Thank you, this is subtle. I'd test this but only whether it fixed
> the error case. I shall test this on all configurations. It'll take a
> few hours.

Ping, Oliver, do you want to send an updated patch, or shall I just fix
your patch myself?  I'll be queuing Han's UAS patches shortly, but your
patch can always go in another pull request.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]