[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb
Subject:    Re: [PATCH 06/16] usb/gadget: convert source sink and loopback to new function interface
From:       Felipe Balbi <balbi () ti ! com>
Date:       2012-11-30 14:51:16
Message-ID: 20121130145116.GD17587 () arwen ! pp ! htv ! fi
[Download RAW message or body]

On Tue, Nov 20, 2012 at 11:53:02PM +0100, Michal Nazarewicz wrote:
> > * Felipe Balbi | 2012-11-20 14:14:47 [+0200]:
> >> now this looks awfully wrong. Why don't you just expose the modules to
> >> userland (in fact they already are) and if user wants to change
> >> something it needs to do it via sysfs before enabling the function ?
> 
> On Tue, Nov 20 2012, Sebastian Andrzej Siewior wrote:
> > This isn't that easy. buflen & qlen here are used for memory allocation.
> > A change here would require to purge all usb_requests and re-allocate
> > them.
> 
> I think that what Felipe means is to let user set the values in sysfs
> before the function is enabled.  Once the function is added to some
> gadget, the values become read only.

spot on.

-- 
balbi

["signature.asc" (application/pgp-signature)]
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[prev in list] [next in list] [prev in thread] [next in thread]