[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-usb
Subject:    Re: [patch] Fix PS3 USB shutdown
From:       David Brownell <david-b () pacbell ! net>
Date:       2008-10-30 19:16:18
Message-ID: 200810301216.18688.david-b () pacbell ! net
[Download RAW message or body]

On Thursday 30 October 2008, Geoff Levand wrote:
> 
> > Why not just call the relevant core shutdown method
> > and then call it quits?  One of the original use cases
> > for shutdown() methods is fast powerdown when the
> > system is malfunctioning.  Those methods should do
> > as little as possible ... and avoid touching things
> > that aren't essential.  Example, touching a corrupted
> > data structure can easily cause needless oopsing.
> 
> I need to release the hypervisor resources so the next kernel
> kexec'ed can acquire them...

OK, then please make make sure there's a comment to
that effect.  I take it there's no place you can
just "release everything"?  The cleanest solution
would be to ensure drivers don't need to be involved
with that sort of thing.  But I can imagine this
hypervisor wasn't necessarily written with kexec()
and similar requirements in mind!

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]